[v11] Fix yum repo cleanup#17338
Merged
Merged
Conversation
Merged
r0mant
approved these changes
Oct 12, 2022
wadells
force-pushed
the
walt/v11-fix-yum-pubish
branch
from
35eccfa to
b99a02b
Compare
fheinecke
approved these changes
Oct 12, 2022
wadells
force-pushed
the
walt/v11-fix-yum-pubish
branch
2 times, most recently
from
e67d318 to
6205713
Compare
Previously, "${ARTIFACT_PATH}" was interpreted as Drone variable
subsitution, resulting in "rm -rf ${ARTIFACT_PATH}/*" becoming
"rm -rf /*", which deleted credentials on the filesystem.
reedloden
force-pushed
the
walt/v11-fix-yum-pubish
branch
from
6205713 to
d359a20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #17334
Previously, "${ARTIFACT_PATH}" was interpreted as Drone variable substitution, resulting in
rm -rf "${ARTIFACT_PATH}/*"becomingrm -rf "/*", which deleted credentials on the filesystem. This causes the error seen here:https://drone.platform.teleport.sh/gravitational/teleport/16371/2/5
Testing
See the testing in #17334